RFR: 8340923: The class LogSelection copies uninitialized memory [v2]

Matthias Baesken mbaesken at openjdk.org
Thu Sep 26 06:08:45 UTC 2024


On Wed, 25 Sep 2024 16:56:03 GMT, Abdelhak Zaaim <duke at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes
>
> I suggest using std::fill(_tags + _ntags, _tags + LogTag::MaxTags, LogTag::__NO_TAG); instead of the manual loop. Its cleaner, easier to read  and takes advantage of the standard library.

> @abdelhak-zaaim HotSpot code is not allowed to use the vast majority of the C++ Standard Library

Would we need to adjust linker settings when using std::fill (in case it would be allowed) ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21185#issuecomment-2376011950


More information about the hotspot-runtime-dev mailing list