RFR: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg [v10]
Afshin Zafari
azafari at openjdk.org
Thu Sep 26 12:22:52 UTC 2024
> In committing a region, it is not mandatory to provide a MEMFLAGS flag where the committed region inherits the flag from the main region it resides in.
> In un-committing there is no need to a MEMFLAGS at all.
> The `register_mapping` API of the VMATree *requires* a MEMFLAGS (via metadata arg) in both of these two operations. To do the flag inheriting, it is possible to copy the flag of the left node in the tree to the newly inserted ones.
>
> An optional bool arg (default is false) is added to VMATree API to copy the existing flag of the left node to the new nodes.
Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- Merge remote-tracking branch 'origin/master' into _8335091_vmatree_copy_mtflag_on_commit
- use_flag_inplace, new test case for uncommit_mapping
- logging/log.hpp is included
- fixed the build failure
- StackIndex update.
- fixed merge conflict
- Johan's change set
- invalid cases of register_mapping are handled.
- reserve always use the flag in metadata
- added uncommit_mapping method.
- ... and 1 more: https://git.openjdk.org/jdk/compare/10da2c21...8993a10b
-------------
Changes: https://git.openjdk.org/jdk/pull/20330/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20330&range=09
Stats: 58 lines in 3 files changed: 45 ins; 1 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/20330.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20330/head:pull/20330
PR: https://git.openjdk.org/jdk/pull/20330
More information about the hotspot-runtime-dev
mailing list