RFR: 8340679: Misc tests fail assert(!set || SafepointSynchronize::is_at_safepoint()) failed: set once or at safepoint

[Ioi Lam]

On Wed, 25 Sep 2024 17:05:11 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> The shared_loading_failed flag is set if an exception is thrown when trying to resolve a super class or interface for [JDK-8338693](https://bugs.openjdk.org/browse/JDK-8338693).  This case then sets the same flag in the caller of load_shared_class.  These InstanceKlass flags assert that we only set them once during class loading then never again. The exception should properly exit out of the call like all other TRAPS functions do.  Then the flag is set in the caller for the exception case.  The other case where shared classes don't match require the boolean return from check_shared_super_type.
> 
> Tested with failing test 1000x, then tier1-4.  Testing all of tier5-7 in progress.

LGTM.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21187#pullrequestreview-2332305650