RFR: 8340491: Thread stack-base assertion should report which thread has the un-set stack [v3]

[Aleksey Shipilev]

On Fri, 20 Sep 2024 06:49:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this simple enhancement to an assertion so we can identify which thread had the problem.
>> 
>> I had to move the function to the cpp file due to include file issues.
>> 
>> We are limited in what we can print due to this being used very early in the thread initialization process - in particular no ResourceMarks are possible so we can't print the name.
>> 
>> Testing:
>>  - tier 5 (used to debug [JDK-8340401](https://bugs.openjdk.org/browse/JDK-8340401))
>>  - tiers 1-3 sanity
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Need ifdef ASSERT

Well, I am still nitpicking about `DEBUG_ONLY(;)`, but I can live with it.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21102#pullrequestreview-2336733708