RFR: 8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier
David Holmes
dholmes at openjdk.org
Tue Apr 1 22:32:12 UTC 2025
On Tue, 1 Apr 2025 17:50:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Java core-lib changes in [JDK-8339280](https://bugs.openjdk.org/browse/JDK-8339280) for code-signing causes more java.lang.invoke classes to be initialized in the assembly phase.
>
> Static fields like `java/lang/invoke/MethodHandleImpl$ArrayAccessor::OBJECT_ARRAY_SETTER` are just cached MethodHandles whose object identity doesn't matter. So it's OK for them to be stored into the AOT cache. Therefore, I added them to the CDSHeapVerifier exclusion lists.
Fix seems fine but I'm worried about how fragile this is. Any core-libs change might result in a change to the early loaded classes and break things again.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24363#pullrequestreview-2734172237
More information about the hotspot-runtime-dev
mailing list