RFR: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path [v3]

Aleksey Shipilev shade at openjdk.org
Wed Apr 2 06:21:14 UTC 2025


On Tue, 1 Apr 2025 21:24:01 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into JDK-8352256-quick-notify-jfr
>>  - Review comment
>>  - Fix
>
> Marked as reviewed by mgronlun (Reviewer).

Thanks @mgronlun! @dholmes-ora, are you happy with our conclusions?

> src/hotspot/share/runtime/synchronizer.cpp line 378:
> 
>> 376:         DTRACE_MONITOR_PROBE(notify, mon, obj, current);
>> 377:       }
>> 378:       do {
> 
> Is this loop included in the refactored version? I guess it is.

Yes, it is inside `notifyAll`. This loop used to run when `all = true` (= notifyAll), and there is a waiter in the wait set. This is the same thing that `notifyAll` is doing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24097#issuecomment-2771445092
PR Review Comment: https://git.openjdk.org/jdk/pull/24097#discussion_r2024138607


More information about the hotspot-runtime-dev mailing list