RFR: 8353718: Improve droppingMessage test in async UL tests [v2]

[Johan Sjölen]

On Sun, 6 Apr 2025 21:45:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do not use BufferUpdater
>
> test/hotspot/gtest/logging/test_asynclog.cpp line 81:
> 
>> 79: 
>> 80:     // shrink async buffer.
>> 81:     //AsyncLogWriter::BufferUpdater saver(1024);
> 
> You have some comments that no longer apply once you comment this out. It is also unclear why you are commenting it out and not just deleting it.

Hi, the TL;DR is that that was a mistake.

The long reason is: I wanted to try skipping the buffer and so I committed and pushed it to make it accessible on my build computer, but I forgot that it's up for a PR. That's actually the reason for all the comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24411#discussion_r2030530924