RFR: 8350753: Deprecate UseCompressedClassPointers [v2]
Thomas Stuefe
stuefe at openjdk.org
Mon Apr 7 09:57:47 UTC 2025
On Mon, 7 Apr 2025 06:19:37 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into JDK-8350753-Deprecate-UseCompressedClassPointers
>> - not on 32-bit
>> - Deprecate UseCompressedClassPointers
>
> src/hotspot/share/runtime/arguments.cpp line 532:
>
>> 530: { "CreateMinidumpOnCrash", JDK_Version::jdk(9), JDK_Version::undefined(), JDK_Version::undefined() },
>> 531: #ifdef _LP64
>> 532: // Note: on 32-bit, the option is not available; therefore a deprecation notice makes no sense.
>
> No need for the comment - the ifdef tells you this is something only for 64-bit
I initially thought a casual reader may interpret the ifdef as "the option is still accepted on 32-bit" - to know otherwise, one has to read globals.hpp. But I am fine with removing the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24436#discussion_r2030892614
More information about the hotspot-runtime-dev
mailing list