RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v7]

[Afshin Zafari]

On Tue, 1 Apr 2025 14:42:22 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix the GHA failures.
>
> src/hotspot/share/nmt/vmatree.cpp line 68:
> 
>> 66:     stB.in.set_commit_stack(metadata.stack_idx);
>> 67:     stA.out.set_reserve_stack(NativeCallStackStorage::invalid);
>> 68:     stB.in.set_reserve_stack(NativeCallStackStorage::invalid);
> 
> Set these as `metadata.stack_idx` to fix the test case below.

Done.

> test/hotspot/gtest/nmt/test_vmatree.cpp line 847:
> 
>> 845:     tree.commit_mapping(0, 100, call_stack_1);
>> 846:     expected(tree, 0, -1, si_1, __LINE__);
>> 847:   }
> 
> Should have both reserve and commit as `si_1`.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2031174410
PR Review Comment: https://git.openjdk.org/jdk/pull/24028#discussion_r2031174149