RFR: 8351661: NMT: VMATree should support separate call-stacks for reserve and commit operations [v8]

Gerard Ziemski gziemski at openjdk.org
Mon Apr 7 17:49:50 UTC 2025


On Mon, 7 Apr 2025 12:37:30 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> In NMT detail mode, we need to have separate call-stacks for Reserve and Commit operations.
>> This PR adds a second stack to every node that will be used when committing (and uncommitting) the start node of a reserved region.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixes. New check_tree impl and visualization.

I like the way we visualize the case, though I'd prefer to spell out both the "pre" and "post" every time (and have them aligned).

-------------

Changes requested by gziemski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24028#pullrequestreview-2747612787


More information about the hotspot-runtime-dev mailing list