RFR: 8171508: Remove -Dsun.java.launcher.is_altjvm option [v4]

[Calvin Cheung]

On Mon, 7 Apr 2025 05:06:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix issues related to JAVA_HOME and gtest
>
> src/hotspot/os/aix/os_aix.cpp line 1309:
> 
>> 1307:   assert(rp != nullptr, "error in realpath(): maybe the 'path' argument is too long?");
>> 1308: 
>> 1309:   if(Arguments::executing_unit_tests()) {
> 
> Suggestion:
> 
>   if (Arguments::executing_unit_tests()) {

Fixed.

> src/hotspot/os/linux/os_linux.cpp line 2775:
> 
>> 2773:   }
>> 2774: 
>> 2775:   if (Arguments::executing_unit_tests()) {
> 
> Suggestion:
> 
>   // If executing unit tests we require JAVA_HOME to point to the real JDK.
>   if (Arguments::executing_unit_tests()) {

Fixed.

> src/hotspot/os/linux/os_linux.cpp line 2802:
> 
>> 2800:         // Use current module name "libjvm.so"
>> 2801:         len = (int)strlen(buf);
>> 2802:         snprintf(buf + len, buflen-len, "/%s/libjvm%s",
> 
> Suggestion:
> 
>         snprintf(buf + len, buflen - len, "/%s/libjvm%s",

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24310#discussion_r2031726619
PR Review Comment: https://git.openjdk.org/jdk/pull/24310#discussion_r2031726138
PR Review Comment: https://git.openjdk.org/jdk/pull/24310#discussion_r2031726434