RFR: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path [v4]
David Holmes
dholmes at openjdk.org
Tue Apr 8 07:49:20 UTC 2025
On Mon, 7 Apr 2025 08:04:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Noticed this while removing OM counters. When doing [JDK-8351187](https://bugs.openjdk.org/browse/JDK-8351187), I apparently forgot to cover a path from `ObjectSynchronizer::quick_notify`, probably due to concurrent renames. I think we can cover this gap while still simplifying the code: let `ObjectMonitor` handle all events, DTrace, JFR, OM stats.
>>
>> Additional testing:
>> - [x] Linux x86_64 server fastdebug, `jdk_jfr`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Do explicit thread
> - Merge branch 'master' into JDK-8352256-quick-notify-jfr
> - Merge branch 'master' into JDK-8352256-quick-notify-jfr
> - Review comment
> - Fix
Looks good - thanks for the updates.
Lets see how this works in practice.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24097#pullrequestreview-2749010051
More information about the hotspot-runtime-dev
mailing list