Integrated: 8353727: HeapDumpPath doesn't expand %p

Kevin Walls kevinw at openjdk.org
Wed Apr 9 14:51:48 UTC 2025


On Mon, 7 Apr 2025 09:05:34 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This is a long-standing oversight: HeapDumpPath does not recognise %p for pid expansion.
> The default filename uses a pid (e.g. java_pid1676937.hprof) but HeapDumpPath does not.
> It has always done a manual "root plus pid plus extension" on the default filename only, and
> should move to using Argument::copy_expand_pid() like we do with other such filenames.
> 
> 
> We also assumed the default filename is not a directory (which is very very likely, but doesn't have to be true).

This pull request has now been integrated.

Changeset: 7a7b9ed7
Author:    Kevin Walls <kevinw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7a7b9ed7fe4a10bca155b0877c3e731f9d343b92
Stats:     71 lines in 2 files changed: 10 ins; 37 del; 24 mod

8353727: HeapDumpPath doesn't expand %p

Reviewed-by: stuefe, lmesnik

-------------

PR: https://git.openjdk.org/jdk/pull/24482


More information about the hotspot-runtime-dev mailing list