RFR: 8171508: Remove -Dsun.java.launcher.is_altjvm option [v6]

[Calvin Cheung]

On Thu, 10 Apr 2025 00:20:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify the code by using stringStream
>
> src/hotspot/os/aix/os_aix.cpp line 1330:
> 
>> 1328: 
>> 1329:       len = strlen(buf);
>> 1330:       assert(len < buflen, "Ran out of buffer room");
> 
> Suggestion:
> 
>       assert(strlen(buf) < buflen, "Ran out of buffer room");
> 
> and then I think the `len` local is unused.

Fixed.

> src/hotspot/os/bsd/os_bsd.cpp line 1524:
> 
>> 1522:       len = strlen(buf);
>> 1523:       assert(len < buflen, "Ran out of buffer space");
>> 1524:       // Add the appropriate library  and JVM variant subdirs
> 
> Suggestion:
> 
>       // Add the appropriate library and JVM variant subdirs

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24310#discussion_r2036512401
PR Review Comment: https://git.openjdk.org/jdk/pull/24310#discussion_r2036512438