RFR: 8171508: Remove -Dsun.java.launcher.is_altjvm option [v5]
Calvin Cheung
ccheung at openjdk.org
Thu Apr 10 19:59:41 UTC 2025
On Tue, 8 Apr 2025 08:16:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>>> Are the Posix variants all identical? If yes, can we move this to os::posix.cpp? If not, what are the differences?
>>
>> AIX has a different dll lookup mechanism, but otherwise these should be pretty much identical. Windows also only really differs in the lookup mechanism. Maybe new RFE to refactor these and share some code?
>
>> > Are the Posix variants all identical? If yes, can we move this to os::posix.cpp? If not, what are the differences?
>>
>> AIX has a different dll lookup mechanism, but otherwise these should be pretty much identical. Windows also only really differs in the lookup mechanism. Maybe new RFE to refactor these and share some code?
>
> Okay. The code could also be simpler if it were to use stringStream, spanned over the caller-provided buffer. No character counting and truncation handling needed then (but we would need to add truncation detection to stringStream, but that is really easy).
Thanks @tstuefe, @dholmes-ora for the review.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24310#issuecomment-2795023245
More information about the hotspot-runtime-dev
mailing list