RFR: 8354446: [BACKOUT] Remove friends for ObjectMonitor

Fri Apr 11 19:55:28 UTC 2025

On Fri, 11 Apr 2025 19:36:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This reverts commit 36069f6efac4fd02393d28f190ab2ab92b113fd3.
> 
> I don't know why we can't call ObjectMonitor::recursions() rather than updating it directly.
> Rerunning tier3.

The problem is that `set_recursions()` asserts _recursions is 0. Before 8354234 it was only called in contexts were that was true. Using `set_recursions()` for individual increments will fail if _recursions is already > 0.

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24599#pullrequestreview-2761454940