RFR: 8353946: Incorrect WINDOWS ifdef in os::build_agent_function_name
Kim Barrett
kbarrett at openjdk.org
Tue Apr 15 01:34:54 UTC 2025
On Tue, 15 Apr 2025 00:50:16 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Trivial fix to add missing underscore: WINDOWS -> _WINDOWS
>
> When the original code was combined into a shared version, the ifdef around this windows-specific part was incorrect.
>
> Testing: sanity builds only. Correctness is by inspection.
>
> There are no tests for static agents that would exercise this code path.
>
> Thanks.
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24641#pullrequestreview-2766243679
More information about the hotspot-runtime-dev
mailing list