RFR: 8298733: Reconsider monitors_on_stack assert [v2]

Fredrik Bredberg fbredberg at openjdk.org
Wed Apr 16 13:02:58 UTC 2025


On Tue, 15 Apr 2025 17:10:07 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated after Patricio's review
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 577:
> 
>> 575:   map.set_include_argument_oops(false);
>> 576:   for (frame f = thread->last_frame(); Continuation::is_frame_in_continuation(ce, f); f = f.sender(&map)) {
>> 577:     StackWatermark* watermark = StackWatermarkSet::get(thread, StackWatermarkKind::gc);
> 
> We could move this outside the loop.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24655#discussion_r2046878430


More information about the hotspot-runtime-dev mailing list