RFR: 8354327: Rewrite runtime/LoadClass/LoadClassNegative.java

Leonid Mesnik lmesnik at openjdk.org
Thu Apr 17 18:41:46 UTC 2025


On Wed, 16 Apr 2025 12:34:28 GMT, Anton Artemov <duke at openjdk.org> wrote:

> Rewrote the test  runtime/LoadClass/LoadClassNegative so that it creates a dummy jar file on the fly and then removes it. Previously existing dummy.jar removed.

The changes looks, good see my comment inline. It is just suggestion, so feel free to implement it or not.

test/hotspot/jtreg/runtime/LoadClass/LoadClassNegative.java line 45:

> 43: 
> 44:     // Create a dummy file in the scratch directory
> 45:     final String filename = "dummy.jar";

Wouldn't better to rename it to empty.jar?

-------------

Marked as reviewed by lmesnik (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24688#pullrequestreview-2776623165
PR Review Comment: https://git.openjdk.org/jdk/pull/24688#discussion_r2049471194


More information about the hotspot-runtime-dev mailing list