RFR: 8354453: Don't strcpy in os::strdup, use memcpy instead

Coleen Phillimore coleenp at openjdk.org
Thu Apr 17 19:00:49 UTC 2025


On Tue, 15 Apr 2025 07:37:54 GMT, Anton Artemov <duke at openjdk.org> wrote:

> Use memcpy instead of strcpy in os::strdup, 1 string pass fewer.

There's a setting to enable GHA (Git Hub Actions) testing, can you turn that on.  Also, please put what testing you did in the description of the PR.  We generally run tier1-3 for small  changes, 4-8 on larger ones, and even more tiers on even largeer ones internally at Oracle.  This seems like a tier1-3 change to me although a little error in memory copying could be intermittent and might require more tests to be run.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24651#issuecomment-2813786406


More information about the hotspot-runtime-dev mailing list