RFR: 8355237: Upstream AOT test cases from Leyden repo to mainline
Calvin Cheung
ccheung at openjdk.org
Tue Apr 22 05:24:51 UTC 2025
On Tue, 22 Apr 2025 04:06:29 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> Adding one test from the Leyden repo to the mainline.
>
> Note: this test was originally developed in 2024 hence the copyright year includes 2024.
Noticed one thing.
test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/StringConcatStress.java line 37:
> 35: * @test id=aot
> 36: * @requires vm.cds
> 37: * @requires vm.cds.supports.aot.class.linking
>From the VMProps.java in the mainline:
protected String vmCDSSupportsAOTClassLinking() {
// Currently, the VM supports AOTClassLinking as long as it's able to write archived java heap.
return vmCDSCanWriteArchivedJavaHeap();
}
The `vmCDSCanWriteArchivedJavaHeap()` already checks for `vmCDS()`.
So it seems the `@requires vm.cds` is redundant.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24789#pullrequestreview-2782789618
PR Review Comment: https://git.openjdk.org/jdk/pull/24789#discussion_r2053348725
More information about the hotspot-runtime-dev
mailing list