RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v6]

[David Holmes]

On Tue, 22 Apr 2025 08:51:30 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> To resolve runtime/os/windows/TestAvailableProcessors.java failure, I made "systeminfo.exe" executed with "chcp 437". This ensures that the English message "OS Version: " is output on localized windows platforms.
>> I added the path C:\Windows\System32 to make chcp command recognized on the GHA Windows test machine. Without this addition, GHA will fail.
>> After this fix, I verified that the test passed.
>> 
>> https://github.com/openjdk/jdk/pull/22142
>> I refer to this fix.
>> tools/jpackage/windows/Win8301247Test.java does not run in GHA, so the problems with recognition of chcp command did not occur before.
>> 
>> Thanks.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into 8349288
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 71:

> 69:             System.getenv("SystemRoot") != null ? new File(System.getenv("SystemRoot")) :
> 70:             System.getenv("WINDIR")     != null ? new File(System.getenv ("WINDIR")) :
> 71:             "";

This change makes no sense - "" is not a File.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23536#pullrequestreview-2785798247
PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r2055159091