RFR: 8353190: Use "/native" Run Option for TestAvailableProcessors Execution [v2]
David Holmes
dholmes at openjdk.org
Wed Apr 23 06:36:49 UTC 2025
On Tue, 22 Apr 2025 19:51:24 GMT, Oleksii Sylichenko <duke at openjdk.org> wrote:
>> Currently, the test executes the program using `test.nativepath`, but it relies on path resolution. I propose following standard conventions in this case and running the test with the `/native` option instead.
>>
>> With this change:
>> - Path resolution is no longer required.
>> - If `nativepath` is not specified at runtime, a standard error message will be printed to the console.
>>
>> This improves consistency and simplifies the test execution process.
>>
>> I kindly ask the original author of the test @swesonga and those who reviewed the original pull request #17576 for this test to take a look at this PR: @jdksjolen and @dholmes
>
> Oleksii Sylichenko has updated the pull request incrementally with one additional commit since the last revision:
>
> 8353190: remove unnecessary option `--enable-native-access=ALL-UNNAMED`
Testing was fine.
LGTM.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23803#pullrequestreview-2786014351
More information about the hotspot-runtime-dev
mailing list