RFR: 8354803: ALL_64_BITS is the same across platforms [v2]

David Holmes dholmes at openjdk.org
Wed Apr 23 11:04:48 UTC 2025


On Tue, 22 Apr 2025 09:11:25 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> We have quite a lot of duplication of ALL_64_BITS
>> #define ALL_64_BITS CONST64(0xFFFFFFFFFFFFFFFF)
>> across posix platforms but it is the same for these platforms so it could be moved to a central place.
>> 
>> On Windows it is currently
>> #define ALL_64_BITS CONST64(-1)
>> but this should be the same too.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   handle windows too

src/hotspot/share/utilities/globalDefinitions.hpp line 165:

> 163: 
> 164: // for timer info max values which include all bits
> 165: #define ALL_64_BITS CONST64(0xFFFFFFFFFFFFFFFF)

I was thinking perhaps

const jlong ALL_64_BITS ...

?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24715#discussion_r2055805536


More information about the hotspot-runtime-dev mailing list