RFR: 8354811: clock_tics_per_sec code duplication between os_linux and os_posix [v2]

Matthias Baesken mbaesken at openjdk.org
Fri Apr 25 12:15:31 UTC 2025


On Fri, 25 Apr 2025 10:44:39 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust os_perf_aix.cpp too
>
> src/hotspot/os/linux/os_linux.cpp line 5133:
> 
>> 5131:                  &user_time, &sys_time);
>> 5132:   if (count != 13) return -1;
>> 5133:   double clock_tics_factor = 1000000000 / os::Posix::clock_tics_per_second();
> 
> I think you should rather not add clock_tics_factor but replace clock_tics_per_sec with os::Posix::clock_tics_per_second() in place, but it's maybe just a matter of taste...

Okay I change it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24720#discussion_r2060125334


More information about the hotspot-runtime-dev mailing list