RFR: 8352003: Support --add-opens with -XX:+AOTClassLinking

[Calvin Cheung]

On Fri, 18 Apr 2025 01:41:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>>> Do we have a test case where `--add-opens` is used both at dump time and run time? That will verify that `--add-opens` at dump time is correctly processed.
>>> 
>> 
>> Yes, the new test `AddopensOption.java` uses the `--add-opens` both at dump time and run time.
>> I have done some minor cleanup on the test, please review the new version.
>
>> > Do we have a test case where `--add-opens` is used both at dump time and run time? That will verify that `--add-opens` at dump time is correctly processed.
>> 
>> Yes, the new test `AddopensOption.java` uses the `--add-opens` both at dump time and run time. I have done some minor cleanup on the test, please review the new version.
> 
> AddopensOption.java only checks if the --add-opens is accepted. It doesn't check if the option has any effect. I think it's better to run `TEST_MODULE1` to make sure that `setAccessible` can be called without throwing an exception. That will verify that the option has achieved the intended effect.

Thanks @iklam @AlanBateman @matias9927 for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24695#issuecomment-2830839597