RFR: 8315719: Adapt AOTClassLinking test case for dynamic CDS archive
Ioi Lam
iklam at openjdk.org
Fri Apr 25 21:01:50 UTC 2025
On Fri, 25 Apr 2025 18:30:09 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> This test case was written only for the static CDS archive. To increase test coverage, I've adapted the test to also test the dynamic CDS archive.
>
> Marked as reviewed by ccheung (Reviewer).
Thanks @calvinccheung for the review
> test/hotspot/jtreg/runtime/cds/appcds/resolvedConstants/ResolvedConstants.java line 46:
>
>> 44: * @summary Dump time resolution of constant pool entries (Dynamic CDS archive)
>> 45: * @requires vm.cds
>> 46: * @requires vm.cds.supports.aot.class.linking
>
> I think `vm.cds.supports.aot.class.linking` implies `vm.cds`. Similarly for the `id=static` case.
> But if you think having the `@requires vm.cds` will make it clearer, it's fine too.
We have many tests that have the same pattern. I think we should do the clean up in a separate RFE.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24866#issuecomment-2831418377
PR Review Comment: https://git.openjdk.org/jdk/pull/24866#discussion_r2060875004
More information about the hotspot-runtime-dev
mailing list