RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v6]

Kazuhisa Takakuri ktakakuri at openjdk.org
Mon Apr 28 07:16:52 UTC 2025


On Wed, 23 Apr 2025 02:39:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8349288
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>>  - 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>
> test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 71:
> 
>> 69:             System.getenv("SystemRoot") != null ? new File(System.getenv("SystemRoot")) :
>> 70:             System.getenv("WINDIR")     != null ? new File(System.getenv ("WINDIR")) :
>> 71:             "";
> 
> This change makes no sense - "" is not a File.

I set it back to null.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r2063028703


More information about the hotspot-runtime-dev mailing list