RFR: 8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform [v4]

Kazuhisa Takakuri ktakakuri at openjdk.org
Mon Apr 28 07:16:53 UTC 2025


On Mon, 14 Apr 2025 08:07:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8349288: runtime/os/windows/TestAvailableProcessors.java fails on localized Windows platform
>
> test/hotspot/jtreg/runtime/os/windows/TestAvailableProcessors.java line 73:
> 
>> 71:             null;
>> 72:         if (systemRoot == null || ! systemRoot.isDirectory())
>> 73:             return; // Not Windows as we know it
> 
> This doesn't compile - the function returns a String.

Even if systemRoot fails to recognize the system, it does not matter if chcp can be executed, so I removed the judgment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23536#discussion_r2063026820


More information about the hotspot-runtime-dev mailing list