RFR: 8355711: Fix incorrect overflow check in RawBytecodeStream::raw_next [v2]

[Johan Sjölen]

On Mon, 28 Apr 2025 20:08:34 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> src/hotspot/share/interpreter/bytecodeStream.hpp line 139:
> 
>> 137:              && code != Bytecodes::_lookupswitch, "can't be special bytecode");
>> 138:       _is_wide = false;
>> 139:       if (INT_MAX - len <= _next_bci) { // Check for integer overflow
> 
> I don't see how we can ever hit this case, given the `_bci <= _end_bci - len` test above.

Hm, that seems right. Then the integer overflow check never did anything at all, anyway, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24920#discussion_r2065542349