RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Apr 29 19:10:51 UTC 2025
On Fri, 25 Apr 2025 14:57:39 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Rewrote JsrRewriting and OomWhileParsingRepeatedJsr tests so that they are not using jar files, but instead class files are created on the fly using the ASM library.
>>
>> Test in tiers 1-3 on multiple platforms pass.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8354329: Got rid of obsolete Applet inheritance, not inheriting from Object.
test/hotspot/jtreg/runtime/ClassFile/JsrRewriting.java line 41:
> 39: * java.desktop
> 40: * java.management
> 41: * @run driver JsrRewriting
See other comment. I think this needs @compile OOMCrashClass1960_1.java. I'm not sure how the test found the class.
test/hotspot/jtreg/runtime/ClassFile/OomWhileParsingRepeatedJsr.java line 41:
> 39: * @modules java.base/jdk.internal.misc
> 40: * java.desktop
> 41: * java.management
I don't see how this test and the other compile the OOMCrashClass1960_2.java file or include it. I think this needs a @compile OOMCrashClass1960_2java above the @run driver line.
Your testing might have picked up an older version of the .class file for OOMCrashClass1960_2?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2067171103
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2067169302
More information about the hotspot-runtime-dev
mailing list