RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Apr 29 19:41:59 UTC 2025
On Tue, 29 Apr 2025 19:17:51 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8354329: Got rid of obsolete Applet inheritance, not inheriting from Object.
>
> test/hotspot/jtreg/runtime/ClassFile/OOMCrashClass4000_1.java line 42:
>
>> 40: */
>> 41:
>> 42: public class OOMCrashClass4000_1 implements Opcodes {
>
> I recommend static importing fields instead of using implements to inherit the public static final interface fields.
>
> Also, is it possible to just use the ClassFile API?
This doesn't use the ClassFile API because it's trying to hack bytecodes for classfile version 49 with JSR/RET, so seems appropriate to use the more legacy classfile writer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2067229970
More information about the hotspot-runtime-dev
mailing list