RFR: 8327495: Print more warning with -Xshare:auto when CDS fails to use archive [v5]
Ioi Lam
iklam at openjdk.org
Wed Apr 30 06:53:46 UTC 2025
On Wed, 30 Apr 2025 04:12:31 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Before this change, if the `-Xshare:auto` is specified with a CDS archive, the user won't see the following error message when the archive has failed to load:
>> `An error has occurred while processing the the shared archive file.`
>> This change will print the above error message if the `-Xshare:auto` is specified and the archive is not the default one.
>> Several existing `log_ino(cds)()` calls have been changed to calling the new function `MetaspaceShared::report_loading_error()`. Also modified couple of tests to check the above error message is printed.
>>
>> Passed tiers 1 - 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> fix build errors on macosx platforms
LGTM.
-------------
Marked as reviewed by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24889#pullrequestreview-2805928427
More information about the hotspot-runtime-dev
mailing list