RFR: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests [v4]
Coleen Phillimore
coleenp at openjdk.org
Wed Apr 30 12:23:54 UTC 2025
On Wed, 30 Apr 2025 08:47:30 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Rewrote JsrRewriting and OomWhileParsingRepeatedJsr tests so that they are not using jar files, but instead class files are created on the fly using the ASM library.
>>
>> Test in tiers 1-3 on multiple platforms pass.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8354329: Got rid of unused variables.
This looks good.
test/hotspot/jtreg/runtime/ClassFile/OomWhileParsingRepeatedJsr.java line 62:
> 60:
> 61: // fill it with the binary data of the class file
> 62: byte[] bytes = OOMCrashClass1960_2.dump();
Okay so class loading triggers java (or jtreg) to compile the OOMCrashClass1960_2.java file then. Thanks for verifying that it is compiled.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24662#pullrequestreview-2806863537
PR Review Comment: https://git.openjdk.org/jdk/pull/24662#discussion_r2068549006
More information about the hotspot-runtime-dev
mailing list