RFR: 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base [v2]
David Holmes
dholmes at openjdk.org
Sun Aug 3 21:18:59 UTC 2025
On Wed, 30 Jul 2025 16:04:00 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Remove from ProblemList
>> - Merge branch 'master' into 8364314-threadSMR
>> - 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base
>
> src/hotspot/share/services/threadService.cpp line 1487:
>
>> 1485: } else {
>> 1486: // We may have previously found a carrier but since unmounted, so
>> 1487: // clear that previous reference.
>
> nit typo: s/but since unmounted/but it since unmounted.
I believe the grammar is correct. It could have said `have since unmounted`, but the `have` is not essential. However as I am expanding the later comment I may as well adjust this one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26544#discussion_r2250138572
More information about the hotspot-runtime-dev
mailing list