RFR: 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base [v2]
David Holmes
dholmes at openjdk.org
Sun Aug 3 21:40:05 UTC 2025
On Wed, 30 Jul 2025 23:51:27 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Remove from ProblemList
>> - Merge branch 'master' into 8364314-threadSMR
>> - 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base
>
> src/hotspot/share/services/threadService.cpp line 1491:
>
>> 1489: }
>> 1490: } else {
>> 1491: java_thread = java_lang_Thread::thread(thread_h());
>
> Preexistent after 8359870, but isn't this redundant? We should already have the target for this case.
Yes you are right. That part of the code was not directly visible in the earlier PRs and it got overlooked. But I would prefer to leave this for @AlanBateman to address as part of the change to remove the transition disabler. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26544#discussion_r2250144245
More information about the hotspot-runtime-dev
mailing list