RFR: 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base [v2]

David Holmes dholmes at openjdk.org
Sun Aug 3 21:50:01 UTC 2025


On Wed, 30 Jul 2025 09:31:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Remove from ProblemList
>>  - Merge branch 'master' into 8364314-threadSMR
>>  - 8364314: java_lang_Thread::get_thread_status fails assert(base != nullptr) failed: Invalid base
>
> Looks reasonable.

Thanks for the reviews @shipilev , @dcubed-ojdk , @pchilano and @sspitsyn .

As noted above this particular code is problematic for a range of reasons, but for now this fix maintains the pretense that the transition disabler actually works, and @AlanBateman will be fixing that as noted above.

Other clients of `cv_internal_thread_to_Java_thread` may potentially have issues if they ever have to deal with virtual threads (they currently don't or else are already being addressed), but that is not related to this fix, nor even the fix applied in JDK-8361912.

Thanks again for the reviews. If someone could re-review the comment changes that would be appreciated. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26544#issuecomment-3148719468


More information about the hotspot-runtime-dev mailing list