RFR: 8263476: NMT: Stack guard pages should not be marked as committed

David Holmes dholmes at openjdk.org
Mon Aug 4 05:00:54 UTC 2025


On Thu, 31 Jul 2025 10:36:59 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Use reserved (instead of committed) memory for stack-guard-pages on linux like systems.
> 
> `os::must_commit_stack_guard_pages` uses `commit` in its name, but `commit` usually has specific meanings in OS memory context. The actual question the caller is asking is whether the caller needs to do some preparation work before marking the guard-pages as inaccessible. To avoid confusion, I changed it to "allocate". Other suggestions are welcome.
> 
> Test: tier1-3

I'm unclear what is actually meant by "commit" in the context of `os::must_commit_memory` but your proposal actually reverses the change that named it this way ([JDK-8159335](https://bugs.openjdk.org/browse/JDK-8159335)):

https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/3950d1713ffa

This also seems a bit different to what @jdksjolen previously suggested in https://github.com/openjdk/jdk/pull/14896/. ??

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26571#issuecomment-3149129649


More information about the hotspot-runtime-dev mailing list