RFR: 8359820: Improve handshake/safepoint timeout diagnostic messages [v7]
Anton Artemov
duke at openjdk.org
Mon Aug 4 08:37:23 UTC 2025
On Mon, 4 Aug 2025 07:59:13 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - 8359820: Addressed reviewer's comments
>> - 8359820: Addressed reviewer's comments
>
> src/hotspot/share/utilities/vmError.cpp line 108:
>
>> 106: const intptr_t VMError::segfault_address = pd_segfault_address;
>> 107: volatile intptr_t VMError::_handshake_timeout_thread = p2i(nullptr);
>> 108: volatile intptr_t VMError::_safepoint_timeout_thread = p2i(nullptr);
>
> Sorry there was a typo in my suggestion - it should be `timed_out` to match the function names. (Or change the functions to use `timedout` - I tend to use `timedout` as a single "word" in these contexts.
Thanks for spotting, addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26309#discussion_r2250798694
More information about the hotspot-runtime-dev
mailing list