RFR: 8364723: Sort share/interpreter includes

Francesco Andreuzzi duke at openjdk.org
Tue Aug 5 10:43:40 UTC 2025


On Tue, 5 Aug 2025 10:38:11 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

> This PR sorts the includes in `hotspot/share/interpreter` using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.
> 
> Passes tier1.

src/hotspot/share/interpreter/zero/bytecodeInterpreter.inline.hpp line 45:

> 43: #endif
> 44: 
> 45: # include "bytecodeInterpreter_zero.inline.hpp"

Does a space between `#` and `include` have any special significance which should be kept throughout reordering?

src/hotspot/share/interpreter/zero/zeroInterpreterGenerator.hpp line 32:

> 30: 
> 31: # include "entry_zero.hpp"
> 32: // # include "interpreter/interp_masm.hpp"

This was commented long time ago (1550fd889b467d9866ac00a3bc7ab1f879e7f20a), I guess it can be removed safely.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26639#discussion_r2253942952
PR Review Comment: https://git.openjdk.org/jdk/pull/26639#discussion_r2253944754


More information about the hotspot-runtime-dev mailing list