RFR: 8263476: Use reserved memory for stack guard pages [v3]
Albert Mingkun Yang
ayang at openjdk.org
Tue Aug 5 12:58:04 UTC 2025
On Tue, 5 Aug 2025 12:01:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Windows only allows you to protect committed pages!
That's true, but it is an implementation detail that should be dealt with inside `os::create_stack_guard_pages` -- the caller `StackOverflow` does not require guard-pages to be committed.
> Yes please do so. I think changing the guard mechanism in this way needs a bit more obvious "socialising". ...
Updated.
> ... but even then I'm not sure that would adequately test your changes.
I have gone through the git-history of `os::pd_create_stack_guard_pages` on linux, but don't see any particular test involved for that area of code. Anyway, I will run higher tiers of tests.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26571#issuecomment-3155103573
More information about the hotspot-runtime-dev
mailing list