RFR: 8364570: Remove LockingMode related code from riscv64
Feilong Jiang
fjiang at openjdk.org
Thu Aug 7 15:20:15 UTC 2025
On Wed, 6 Aug 2025 11:24:22 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
> Since the integration of [JDK-8359437](https://bugs.openjdk.org/browse/JDK-8359437) the `LockingMode` flag can no longer be set by the user, instead it's declared as `const int LockingMode = LM_LIGHTWEIGHT;`. This means that we can now safely remove all `LockingMode` related code from all platforms.
>
> This PR removes `LockingMode` related code from the **riscv64** platform.
>
> When all the `LockingMode` code has been removed from all platforms, we can go on and remove it from shared (non-platform specific) files as well. And finally remove the `LockingMode` variable itself.
Looks good, with one minor comment.
src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 1821:
> 1819: __ ld(obj_reg, Address(oop_handle_reg, 0));
> 1820:
> 1821: Label done, not_recursive;
label `done` is not used either. We can just remove it.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26658#pullrequestreview-3097623099
PR Review Comment: https://git.openjdk.org/jdk/pull/26658#discussion_r2260643213
More information about the hotspot-runtime-dev
mailing list