RFR: 8365050: Too verbose warning in os::commit_memory_limit() on Windows
David Holmes
dholmes at openjdk.org
Fri Aug 8 02:44:10 UTC 2025
On Thu, 7 Aug 2025 16:38:21 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> This is a follow-up to [JDK-8364518](https://bugs.openjdk.org/browse/JDK-8364518), which introduced support for Job Objects in os::commit_memory_limit() on Windows. The single `warning(...)` turned out to be too verbose, as getting an error from `QueryInformationJobObject` is common when the process is not in a job and does not have permission to query information about a job. The verbosity results both in a lot of warning prints when building, and some tests to fail, which expects the output to contain something specific or nothing at all. See more details in the JBS issue.
>
> To address this, I suggest we revise os::commit_memory_limit() to first check if the process is in a job before calling `QueryInformationJobObject`. When testing this locally, I can see that the verbose warnings when building are gone and the tests pass.
>
> I'll run this through internal Oracle testing as well.
Looks okay.
Sorry I should have realized we needed the same checks as for the CPU query.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26680#pullrequestreview-3099299754
More information about the hotspot-runtime-dev
mailing list