RFR: 8365050: Too verbose warning in os::commit_memory_limit() on Windows

[Joel Sikström]

On Mon, 11 Aug 2025 08:11:15 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Hello,
>> 
>> This is a follow-up to [JDK-8364518](https://bugs.openjdk.org/browse/JDK-8364518), which introduced support for Job Objects in os::commit_memory_limit() on Windows. The single `warning(...)` turned out to be too verbose, as getting an error from `QueryInformationJobObject` is common when the process is not in a job and does not have permission to query information about a job. The verbosity results both in a lot of warning prints when building, and some tests to fail, which expects the output to contain something specific or nothing at all. See more details in the JBS issue.
>> 
>> To address this, I suggest we revise os::commit_memory_limit() to first check if the process is in a job before calling `QueryInformationJobObject`. When testing this locally, I can see that the verbose warnings when building are gone and the tests pass.
>> 
>> Testing:
>> * Oracle's tier1-4
>> * Reported test failures now pass
>
> Windows tests with this patch look good, without it  LOTS of failures - so can this be integrated ?

@MBaesken Yes, lets ship it. Sorry for the delay.
Thank you both for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26680#issuecomment-3173709843