RFR: 8364570: Remove LockingMode related code from riscv64 [v2]

Fredrik Bredberg fbredberg at openjdk.org
Tue Aug 12 10:02:17 UTC 2025


On Sun, 10 Aug 2025 08:28:39 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update one after review
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 743:
> 
>> 741:   const Register tmp3 = c_rarg5;
>> 742: 
>> 743:   Label slow_case;
> 
> Nit: Maybe declare the two Labels `done` and `slow_case` on the same line.
> `Label slow_case, done;`

Fixed

> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 745:
> 
>> 743:   Label slow_case;
>> 744: 
>> 745:   // Load object pointer into obj_reg c_rarg3
> 
> Suggestion: `// Load object pointer into obj_reg (c_rarg3)`

Fixed

> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 785:
> 
>> 783:   save_bcp(); // Save in case of exception
>> 784: 
>> 785:   // Load oop into obj_reg(c_rarg3)
> 
> Suggestion: `// Load oop into obj_reg (c_rarg3)`

Fixed

> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 791:
> 
>> 789:   sd(zr, Address(lock_reg, BasicObjectLock::obj_offset()));
>> 790: 
>> 791:   Label slow_case;
> 
> Similar here. We can declare the two Labels `done` and `slow_case` on the same line.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26658#discussion_r2269335286
PR Review Comment: https://git.openjdk.org/jdk/pull/26658#discussion_r2269336505
PR Review Comment: https://git.openjdk.org/jdk/pull/26658#discussion_r2269336934
PR Review Comment: https://git.openjdk.org/jdk/pull/26658#discussion_r2269335881


More information about the hotspot-runtime-dev mailing list