RFR: 8365512: Replace -Xcomp with -Xmixed for AOT assembly phase
Aleksey Shipilev
shade at openjdk.org
Thu Aug 14 13:43:12 UTC 2025
On Thu, 14 Aug 2025 13:21:49 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/share/cds/cdsConfig.cpp line 652:
>>
>>> 650: // -Xcomp triggers blocking compilation for all called methods,
>>> 651: // but during AOT assembly phase we should AOT compile in parallel
>>> 652: // (and not blocking) only methods collected during training run.
>>
>> Suggestion:
>>
>> // Improve testing time with AOT and -Xcomp.
>> // AOT assembly phase compiles methods collected during training run
>> // with blocking compilation requests. There is no reason to compile the rest
>> // of the core/infrastructure methods with aggressive/blocking compilation.
>
> Thank you @shipilev for looking on this.
>
>> with blocking compilation requests.
>
> AOT compilation requests are not blocking. We submit bunch of requests for the same compilation level and only then wait when queues are empty.
>
> With -Xcomp we wait each compilation request.
>
> So I want to use "with non-blocking compilation requests. ". There rest of suggested comment is fine.
Ah yes, right, d'uh. I wrote some of that code! Let me rewrite the comment...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26767#discussion_r2276663001
More information about the hotspot-runtime-dev
mailing list