RFR: 8365146: Remove LockingMode related code from ppc64 [v2]
Axel Boldt-Christmas
aboldtch at openjdk.org
Tue Aug 19 09:21:47 UTC 2025
On Tue, 12 Aug 2025 13:12:33 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> Since the integration of [JDK-8359437](https://bugs.openjdk.org/browse/JDK-8359437) the `LockingMode` flag can no longer be set by the user, instead it's declared as `const int LockingMode = LM_LIGHTWEIGHT;`. This means that we can now safely remove all `LockingMode` related code from all platforms.
>>
>> This PR removes `LockingMode` related code from the **ppc64** platform.
>>
>> When all the `LockingMode` code has been removed from all platforms, we can go on and remove it from shared (non-platform specific) files as well. And finally remove the `LockingMode` variable itself.
>
> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into 8365146_remove_lockingmode_ppc64
> - 8365146: Remove LockingMode related code from ppc64
Looks good. Just need to remove some declarations in `src/hotspot/cpu/ppc/macroAssembler_ppc.hpp`
src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2675:
> 2673: // "The box" is the space on the stack where we copy the object mark.
> 2674: void MacroAssembler::compiler_fast_lock_object(ConditionRegister flag, Register oop, Register box,
> 2675: Register temp, Register displaced_header, Register current_header) {
Need to remove the declarations in the hpp file as well.
src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2799:
> 2797:
> 2798: void MacroAssembler::compiler_fast_unlock_object(ConditionRegister flag, Register oop, Register box,
> 2799: Register temp, Register displaced_header, Register current_header) {
Need to remove the declarations in the hpp file as well.
-------------
Marked as reviewed by aboldtch (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26697#pullrequestreview-3131439894
PR Review Comment: https://git.openjdk.org/jdk/pull/26697#discussion_r2284643473
PR Review Comment: https://git.openjdk.org/jdk/pull/26697#discussion_r2284644000
More information about the hotspot-runtime-dev
mailing list