RFR: 8365814: Consolidate has_been_archived() and has_been_buffered() in ArchiveBuilder

Coleen Phillimore coleenp at openjdk.org
Wed Aug 20 13:25:41 UTC 2025


On Wed, 20 Aug 2025 04:01:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Merged the two methods into one: `ArchiveBuilder::has_been_archived()`. Added comments and asserts to explain what the expected result is.

src/hotspot/share/cds/archiveBuilder.hpp line 448:

> 446:   bool has_been_archived(address src_addr) const;
> 447:   template <typename T> bool has_been_archived(T src_addr) const {
> 448:     return has_been_archived((address)src_addr);

What's the point of having a template if you're going to erase the type?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26853#discussion_r2288159601


More information about the hotspot-runtime-dev mailing list