RFR: 8365765: thread.inline.hpp includes the wrong primary header file

[Stefan Karlsson]

On Fri, 22 Aug 2025 08:57:54 GMT, Paul Hübner <duke at openjdk.org> wrote:

> Hi all,
> 
> This ensures `thread.inline.hpp` adheres to the style guide:
>> All .inline.hpp files should include their corresponding .hpp file as the first include line with a blank line separating it from the rest of the include lines. [...]
> 
> I've run tests with JDK tiers 1-3 on macOS (AArch64, x64), Linux (AArch64, x64), and Windows (x64); all green.

Thanks for cleaning this up!

I've left a nit that I'd like to get fixed.

Given that this PR changes the include headers it would be prudent to explicitly test building with precompiled headers disabled (Configure flag --disable-precompiled-headers) in addition to running tier1 testing.

src/hotspot/share/runtime/thread.inline.hpp line 29:

> 27: #define SHARE_RUNTIME_THREAD_INLINE_HPP
> 28: 
> 29: #include "thread.hpp"

We tend to include the directory even if it is implied by the current file's location.

Suggestion:

#include "runtime/thread.hpp"

-------------

Changes requested by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26896#pullrequestreview-3143789922
PR Review Comment: https://git.openjdk.org/jdk/pull/26896#discussion_r2293208048