RFR: 8361370: runtime/Thread/TestThreadDumpMonitorContention.java fails due to time out on Windows [v2]

[David Holmes]

On Fri, 22 Aug 2025 11:07:17 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Hi, please consider the following changes:
>> 
>> Jstack streaming output should be disabled in the test as JDK-8354461 suggest. 
>> 
>> When disabled, the test does not hang with ZGC enabled. 
>> 
>> Tested locally.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8361370: Added explanatory comment.

Per discussions in JBS this change to the test seems fine. Some minor edits on the comment needed.

Thanks.

test/hotspot/jtreg/runtime/Thread/TestThreadDumpMonitorContention.java line 56:

> 54:     // the attach streaming output is enabled and the tool output is lengthy we can get both buffers (the attach
> 55:     // channel and the tool redirection buffer) full and the test hangs.
> 56:     // Instead the attach operation output is buffered and is sent after the operation is completed

Suggestion:

    // jstack streaming output should be disabled because if the attach operation is executed at a safepoint,
    // the attach streaming output is enabled, and the tool output is lengthy, then we can get both buffers (the attach
    // channel and the tool redirection buffer) full and the test hangs.
    // Instead the attach operation output is buffered and is sent after the operation is completed.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26895#pullrequestreview-3153998943
PR Review Comment: https://git.openjdk.org/jdk/pull/26895#discussion_r2299829682